test: add comprehensive E2E authentication tests#117
Closed
jakebromberg wants to merge 3 commits intofeat/better-auth-corefrom
Closed
test: add comprehensive E2E authentication tests#117jakebromberg wants to merge 3 commits intofeat/better-auth-corefrom
jakebromberg wants to merge 3 commits intofeat/better-auth-corefrom
Conversation
Deploying wxyc-dj with
|
| Latest commit: |
e11bf9d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a8bee099.dj-site.pages.dev |
| Branch Preview URL: | https://test-e2e-auth-tests.dj-site.pages.dev |
jakebromberg
force-pushed
the
test/e2e-auth-tests
branch
from
84a452f to
20ee7c2
Compare
jakebromberg
force-pushed
the
feat/better-auth-features
branch
from
85f5c6e to
5dca929
Compare
4 tasks
jakebromberg
force-pushed
the
feat/better-auth-features
branch
from
5dca929 to
917c9bc
Compare
Infrastructure: - Add Playwright configuration for E2E testing - Create reusable page objects for auth flows - Implement auth fixtures with session reuse - Add helper scripts for E2E test environment Test suites: - Login and logout flows - Session navigation and persistence - Password reset flows - Onboarding for new users - Admin role management (promote/demote) - User creation and deletion - Role-based access control CI/CD: - Add GitHub Actions workflow for E2E tests - Add CI workflow for lint, typecheck, and unit tests
jakebromberg
force-pushed
the
test/e2e-auth-tests
branch
from
20ee7c2 to
2e75535
Compare
jakebromberg
changed the base branch from
feat/better-auth-features
to
feat/better-auth-core
Add cross-cutting capabilities (editor, webmaster) management: - Capability toggle chips in roster table for each user - API endpoint for updating user capabilities - Updated Account type and BetterAuthUser conversion - Unit tests for capability handling
3 tasks
Member
Author
Cross-repo coordinationThis PR is part of a coordinated change to add cross-cutting capabilities (editor, webmaster) to the auth system:
These should be merged in order: shared → backend → dj-site |
jakebromberg
force-pushed
the
test/e2e-auth-tests
branch
from
fcd5d25 to
0fff358
Compare
Self-service flow: - Add EmailChangeModal component with password verification - Update SettingsPopup with read-only email field and change button - Verification email sent to new address before change takes effect Admin override flow: - Add inline email editing to roster AccountEntry - Admin changes bypass verification (emailVerified: true) - Confirmation dialog warns about immediate effect Tests: - Unit tests for EmailChangeModal (16 tests) - E2E tests for self-service flow (13 tests) - E2E tests for admin flow (11 tests) - New settings.page.ts and roster.page.ts email methods
jakebromberg
force-pushed
the
test/e2e-auth-tests
branch
from
0fff358 to
e11bf9d
Compare
JacksonMeade
requested changes
Feb 3, 2026
| /** | ||
| * Update user capabilities via API | ||
| */ | ||
| const updateCapabilities = async (newCapabilities: Capability[]) => { |
Collaborator
There was a problem hiding this comment.
This should probably use redux, which I added in order to avoid performing fetching on components, so that state was reusable. Certainly worth a discussion.
Member
Author
|
Closing: Superseded. E2E tests will be added in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a comprehensive Playwright E2E test suite for all authentication functionality.
Dependencies
This PR builds on #116 (
feat/better-auth-features) and should be merged after it.Changes
Infrastructure
Test Suites
CI/CD
Test Plan
Note
This is PR 3 of 3. Merge order: #115 → #116 → this PR